Alexander Larsson [Wed, 24 Apr 2019 11:28:11 +0000 (13:28 +0200)]
GskGLRenderer: Add debug groups
This adds debug groups in various places, including the debug
nodes if those are in use. This makes the traces in tools like
renderdoc much easier to read.
Alexander Larsson [Wed, 24 Apr 2019 11:27:43 +0000 (13:27 +0200)]
GskGLRenderer: Label various gl objects
This means the names are more useful in tools like renderdoc.
Alexander Larsson [Wed, 24 Apr 2019 11:25:46 +0000 (13:25 +0200)]
GdkGLContext: Add internal functions for KHR_DEBUG calls
This includes pushing and poping debug group messages and labeling
objects.
Matthias Clasen [Thu, 25 Apr 2019 01:18:54 +0000 (01:18 +0000)]
Merge branch 'parent-surface' into 'master'
Drop the parent surface getter and setter
See merge request GNOME/gtk!774
Matthias Clasen [Thu, 25 Apr 2019 00:54:56 +0000 (20:54 -0400)]
widget: Drop gtk_widget_set_parent_surface
And the getter, too. Widgets no longer have
extra surfaces that could serve as parent surfaces.
Matthias Clasen [Thu, 25 Apr 2019 00:54:25 +0000 (20:54 -0400)]
popover: Stop using gtk_widget_get_parent_surface
We can just use the surface of the parent.
Matthias Clasen [Thu, 25 Apr 2019 00:56:43 +0000 (20:56 -0400)]
tests: Stop using gtk_widget_get_parent_surface
We can just use the surface of the parent.
Matthias Clasen [Thu, 25 Apr 2019 00:54:05 +0000 (20:54 -0400)]
a11y: Stop using gtk_widget_get_parent_surface
We can just use the surface of the parent.
Matthias Clasen [Wed, 24 Apr 2019 19:26:27 +0000 (19:26 +0000)]
Merge branch 'wip/widget-position-changed-callbacks' into 'master'
widget: Add surface relative position changed callback
See merge request GNOME/gtk!760
Matthias Clasen [Wed, 24 Apr 2019 19:23:12 +0000 (19:23 +0000)]
Merge branch 'fix-and-improve-linked-button-style' into 'master'
themes: Fix and improve linked button style
Closes #1294
See merge request GNOME/gtk!730
Matthias Clasen [Wed, 24 Apr 2019 19:08:40 +0000 (19:08 +0000)]
Merge branch 'wip/jimmac/type-experiments' into 'master'
Adwaita: generic type styles
See merge request GNOME/gtk!772
Jakub Steiner [Thu, 11 Apr 2019 12:50:56 +0000 (14:50 +0200)]
Adwaita: generic type styles
- try to define a basic typographic structure
See https://gitlab.gnome.org/GNOME/gtk/issues/1808
Matthias Clasen [Wed, 24 Apr 2019 16:56:40 +0000 (16:56 +0000)]
Merge branch 'csserror-g-decls' into 'master'
csserror: Add G_BEGIN_DECLS and G_END_DECLS
See merge request GNOME/gtk!773
Timm Bäder [Wed, 24 Apr 2019 15:55:14 +0000 (17:55 +0200)]
gl renderer: Keep op builder around
GL keeps the unoform state per-program, but not per-frame. So, we can't
pretend that this works for us. Keep the RenderOpBuilder around for the
entire lifetime of the renderer instead.
Kjell Ahlstedt [Wed, 24 Apr 2019 14:32:54 +0000 (16:32 +0200)]
csserror: Add G_BEGIN_DECLS and G_END_DECLS
Necessary when the header file is included in C++ code.
Merge request !773
Jonas Ådahl [Thu, 18 Apr 2019 16:55:13 +0000 (18:55 +0200)]
widget: Add surface relative transform changed callback
Added two new private GtkWidget API:
* gtk_widget_add_surface_transform_changed_callback()
* gtk_widget_remove_surface_transform_changed_callback()
The intention is to let the user know when a widget transform relative
to the surface changes. It works by calculating the surface relative
transform during allocation, and notifying the callbacks if it changed
since last time. Each widget adds itself as a listener to its parent
widget, thus will be triggered if a parents surface relative transform
changes.
Timm Bäder [Wed, 24 Apr 2019 10:56:44 +0000 (12:56 +0200)]
gl renderer: Sync gpu and cpu default alpha value
Otherwise we might end up not passing the new value to the GPU.
Timm Bäder [Wed, 24 Apr 2019 10:56:23 +0000 (12:56 +0200)]
gl renderer: Properly apply opacity in cross-fade shader
Daniel Mustieles [Wed, 24 Apr 2019 07:52:46 +0000 (09:52 +0200)]
Updated Spanish translation
Matthias Clasen [Tue, 23 Apr 2019 21:39:29 +0000 (21:39 +0000)]
Merge branch 'simplify-fixes' into 'master'
Simplify fixes
See merge request GNOME/gtk!770
Matthias Clasen [Tue, 23 Apr 2019 21:30:00 +0000 (17:30 -0400)]
builder-tool: Check canonical names
Always canonicalize names before comparing.
We were missing properties like left_attach,
since we were comparing them to left-attach.
Matthias Clasen [Tue, 23 Apr 2019 21:25:59 +0000 (21:25 +0000)]
builder-tool: Fix property check
Embarrassingly, there was a missing else
causing us to check all packing properties
as object properties, never finding them.
Timm Bäder [Tue, 23 Apr 2019 15:24:19 +0000 (17:24 +0200)]
eventcontrollermotion: Document missing signal parameters
Timm Bäder [Tue, 23 Apr 2019 15:24:07 +0000 (17:24 +0200)]
cssprovider: Fix a parameter name mismatch
Benjamin Otte [Tue, 19 Mar 2019 02:57:04 +0000 (03:57 +0100)]
testsuite: Don't pretend we're a GTest
This is a meson test, not a GTest thing. So:
- Use g_print(), not g_test_message
That makes meson test --verbose print the actual log messsages.
- Don't g_assert() all the time
Instead, run tests through to the end and just return a non-0 exit
status.
Timm Bäder [Mon, 22 Apr 2019 12:20:02 +0000 (14:20 +0200)]
gl renderer: begin/end_frame around do_render
This fixes rendering to a texture on intel hardware. The glClear calls
would throw a GL_FRAMEBUFFER_INCOMPLETE error here, because the
gsk_gl_driver_begin_frame() call in do_render() reset the framebuffer
object in use.
Timm Bäder [Mon, 22 Apr 2019 09:31:12 +0000 (11:31 +0200)]
GdkWaylandDevice: Don't recreate the default cursor every frame
Save the information whether the cursor in use is the default one, and
don't create a new cursor object in that case.
We previously created a new cursor object every frame just to compare it
to the current cursor in use and then throw it away.
Daniel Mustieles [Tue, 23 Apr 2019 08:30:35 +0000 (10:30 +0200)]
Updated Spanish translation
Daniel Mustieles [Tue, 23 Apr 2019 08:29:32 +0000 (10:29 +0200)]
Updated Spanish translation
Matthias Clasen [Tue, 23 Apr 2019 01:37:39 +0000 (01:37 +0000)]
Merge branch 'forgotten-file' into 'master'
window: Remove dropped api from headers
See merge request GNOME/gtk!769
Matthias Clasen [Tue, 23 Apr 2019 01:23:01 +0000 (01:23 +0000)]
window: Remove dropped api from headers
This was forgotten in
fed2db1493606342.
Benjamin Otte [Sun, 21 Apr 2019 18:08:05 +0000 (20:08 +0200)]
gdk: Remove gdk_surface_invalidate_rect() from public API
It's still available for backends, but public API (read: GTK) is
meant to only call gdk_surface_queue_expose() and track its
invalid region itself.
Matthias Clasen [Sun, 21 Apr 2019 15:41:25 +0000 (15:41 +0000)]
Merge branch 'unused-typehint' into 'master'
gdk: Remove an unused field
See merge request GNOME/gtk!767
Matthias Clasen [Sun, 21 Apr 2019 15:18:22 +0000 (11:18 -0400)]
gdk: Remove an unused field
Its not used, so get rid of it.
Matthias Clasen [Sat, 20 Apr 2019 02:46:26 +0000 (02:46 +0000)]
Merge branch 'drop-skip-pager' into 'master'
window: Drop some x11-specific apis
See merge request GNOME/gtk!766
Matthias Clasen [Sat, 20 Apr 2019 01:38:12 +0000 (01:38 +0000)]
surface: Drop group api
This was only ever implemented on X11, and
GTK is not using it at all. Relegate it to
x11-specific api.
Matthias Clasen [Sat, 20 Apr 2019 01:13:41 +0000 (01:13 +0000)]
window: Drop some x11-specific apis
The skip-taskbar, skip-pager and urgency hints were
only ever implemented for X11, and are not very useful
with modern desktops. Relegate the functionality to
x11 backend api, and drop the GtkWindow api.
Matthias Clasen [Sat, 23 Mar 2019 04:13:15 +0000 (00:13 -0400)]
Fix a compiler warning
Matthias Clasen [Wed, 20 Mar 2019 00:04:49 +0000 (20:04 -0400)]
wayland: Improve debug output for events
We were missing surfaces in a few places.
Benjamin Otte [Fri, 19 Apr 2019 01:48:59 +0000 (01:48 +0000)]
Merge branch 'cairo-borders-fixage' into 'master'
Cairo borders fixage
See merge request GNOME/gtk!765
Benjamin Otte [Fri, 19 Apr 2019 01:37:55 +0000 (03:37 +0200)]
rendernode: Fix border rendering
This fixed the reftest introduced in the previous commit.
I'm using a mesh gradient here instead of drawing 4 individual sides to
avoid artifacts when those sides overlap in rounded corners.
Benjamin Otte [Fri, 19 Apr 2019 00:28:37 +0000 (02:28 +0200)]
reftests: Add a reftest for rendering failure
c18d2872f292607c921c959e6e97c4d6635bdfd2 introduced a misrendering in
the Cairo fallback rendering code while fixing another one.
This test exposes that problem.
Related: !756
Matthias Clasen [Thu, 18 Apr 2019 20:15:39 +0000 (20:15 +0000)]
window: Fix an oversight
We must still reset cursors.
Matthias Clasen [Thu, 18 Apr 2019 19:38:56 +0000 (19:38 +0000)]
Merge branch 'cursor-things' into 'master'
Cursor things
See merge request GNOME/gtk!764
Matthias Clasen [Thu, 18 Apr 2019 19:07:01 +0000 (15:07 -0400)]
window: Stop juggling cursors
We have convenience api for this.
Matthias Clasen [Thu, 18 Apr 2019 19:06:35 +0000 (15:06 -0400)]
text: Stop juggling cursors
We have a convenience api for this.
Matthias Clasen [Thu, 18 Apr 2019 19:06:09 +0000 (15:06 -0400)]
label: Stop juggling cursors
We have a convenience api for this.
Matthias Clasen [Thu, 18 Apr 2019 18:20:06 +0000 (18:20 +0000)]
Merge branch 'style-prop-change' into 'master'
Style prop change
See merge request GNOME/gtk!763
Matthias Clasen [Thu, 18 Apr 2019 18:08:10 +0000 (18:08 +0000)]
css: Kerning affects text size
Thats the point. And we were missing the proper
flags to make GTK do the right thing when
changing font-kerning in the inspector.
Matthias Clasen [Thu, 18 Apr 2019 18:04:58 +0000 (18:04 +0000)]
css: Some updates to internal docs
Minor corrections to the AFFECTS flags docs.
Matthias Clasen [Thu, 18 Apr 2019 17:46:35 +0000 (17:46 +0000)]
Merge branch 'letterspacing-resize' into 'master'
css: Letterspacing affects text size
See merge request GNOME/gtk!762
Carlos Garnacho [Thu, 18 Apr 2019 17:35:45 +0000 (17:35 +0000)]
Merge branch 'wip/carlosg/tablet-cursors-hidpi-master' into 'master'
gdk/wayland: Listen to wl_surface events on tablet cursors
Closes #1675
See merge request GNOME/gtk!761
Matthias Clasen [Thu, 18 Apr 2019 17:34:44 +0000 (17:34 +0000)]
css: Letterspacing affects text size
It does. And we were missing the proper
flags to make GTK do the right thing when
changing letter-spacing in the inspector.
Carlos Garnacho [Thu, 18 Apr 2019 17:31:55 +0000 (19:31 +0200)]
gdk/wayland: Listen to wl_surface events on tablet cursors
And update the surface accordingly (eg. scale on hidpi). The mechanism
that did that for wl_pointer has been made generic so it can be shared
with tablets too.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1675
Matthias Clasen [Thu, 18 Apr 2019 16:55:28 +0000 (16:55 +0000)]
Merge branch 'handle-tool-scale-fix' into 'master'
gdkdevice-wayland: Update pointer scale on tablet tool proximity events
See merge request GNOME/gtk!582
Jonas Ådahl [Thu, 18 Apr 2019 14:35:06 +0000 (14:35 +0000)]
Merge branch 'wayland-cursor-hotspot' into 'master'
wayland: Avoid using uninitialized memory
Closes #1328
See merge request GNOME/gtk!757
Matthias Clasen [Thu, 18 Apr 2019 14:22:48 +0000 (14:22 +0000)]
wayland: Avoid using uninitialized memory
_gdk_wayland_cursor_get_buffer was not initializing
its out variables in the 'not found' case. This
was showing up in protocol traces as garbage hotspots
being sent to the compositor.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1328
Benjamin Otte [Thu, 18 Apr 2019 00:18:42 +0000 (02:18 +0200)]
testsuite: Add theme-validate test
The test just loads all of GTK's themes and makes sure they cause no
errors or warnings from the CSS parser.
Benjamin Otte [Thu, 18 Apr 2019 00:24:41 +0000 (02:24 +0200)]
themes: Regenerate CSS
Seems to have been forgotten a few times.
Benjamin Otte [Thu, 18 Apr 2019 00:05:58 +0000 (02:05 +0200)]
cssprovider: Export correct API
gtk_css_provider_get_named() is the old GTK3 style API to load themes.
Instead, export the function we currently use,
gtk_css_provider_load_named().
As a side effect we allow people to load a theme as often as they want
without conflicting with GTK's theme.
Matthias Clasen [Thu, 18 Apr 2019 00:12:34 +0000 (00:12 +0000)]
Survive absence of librsvg without criticals
We can't guarantee that we can load svgs, so
we shouldn't spew criticals when some of our
own resources fail to load due to that reason.
Matthias Clasen [Thu, 18 Apr 2019 00:08:16 +0000 (00:08 +0000)]
Avoid a crash without librsvg
gtk_css_image_recolor_load_texture may leave
recolor->text as NULL without setting error.
No need to crash for that.
Matthias Clasen [Wed, 17 Apr 2019 23:54:10 +0000 (23:54 +0000)]
HighContrast: Fix a typo
The new css parser complains about an unknown pseudo-class
here.
Matthias Clasen [Wed, 17 Apr 2019 23:21:29 +0000 (23:21 +0000)]
textview: Refine touch popup
The touch popup was meant to have linked buttons.
Matthias Clasen [Wed, 17 Apr 2019 23:20:04 +0000 (23:20 +0000)]
text: Refine the touch popup
The touch popup was meant to have linked buttons.
Matthias Clasen [Wed, 17 Apr 2019 22:27:19 +0000 (22:27 +0000)]
Add a png version of process-working-symbolic
Otherwise, we get a spinning missing-image without
librsvg.
Matthias Clasen [Wed, 17 Apr 2019 17:37:01 +0000 (17:37 +0000)]
Merge branch 'wip/otte/werror' into 'master'
CI: Build with --werror
See merge request GNOME/gtk!755
Benjamin Otte [Wed, 17 Apr 2019 16:53:53 +0000 (18:53 +0200)]
CI: Build with --werror
This turns on --werror in the Fedora CI builds.
Benjamin Otte [Wed, 17 Apr 2019 16:51:06 +0000 (16:51 +0000)]
Merge branch 'wip/otte/warnings' into 'master'
Add more gcc error flags
See merge request GNOME/gtk!537
Matthias Clasen [Wed, 17 Apr 2019 01:27:17 +0000 (21:27 -0400)]
Remove two more plusses
Matthias Clasen [Wed, 17 Apr 2019 01:19:13 +0000 (01:19 +0000)]
Merge branch 'icon-browser-tweaks' into 'master'
Icon browser tweaks
See merge request GNOME/gtk!754
Matthias Clasen [Wed, 17 Apr 2019 01:13:40 +0000 (21:13 -0400)]
dialog: Fix a doc typo
Matthias Clasen [Wed, 17 Apr 2019 01:13:16 +0000 (21:13 -0400)]
builder-tool: Tweak --help output
Matthias Clasen [Wed, 17 Apr 2019 01:07:26 +0000 (01:07 +0000)]
Merge branch 'gtk-demo-inspector' into 'master'
gtk-demo: Add a gear menu
See merge request GNOME/gtk!753
Matthias Clasen [Wed, 17 Apr 2019 01:00:47 +0000 (21:00 -0400)]
icon-browser: Left-align the sidebar
The centered labels just look disorderly.
Matthias Clasen [Wed, 17 Apr 2019 00:59:57 +0000 (20:59 -0400)]
icon-browser: Recover from GtkDialog api change
When we moved content_area to a sibling of action area,
it changed orientation from vertical to horizontal.
Adapt to this change.
Matthias Clasen [Wed, 17 Apr 2019 00:34:59 +0000 (20:34 -0400)]
gtk-demo: Add a gear menu
Modernize the about dialog, and make it available
from a gear menu, together with a way to bring up
the inspector.
Matthias Clasen [Tue, 16 Apr 2019 23:47:14 +0000 (23:47 +0000)]
Merge branch 'widget-factory-inspector' into 'master'
Widget factory inspector
See merge request GNOME/gtk!752
Matthias Clasen [Tue, 16 Apr 2019 22:09:46 +0000 (18:09 -0400)]
widget-factory: Update copyright line
Update the years to 2019, and use some better typography.
Matthias Clasen [Tue, 16 Apr 2019 22:06:12 +0000 (18:06 -0400)]
widget-factory: Add an Inspector menu item
Just because we can.
Timm Bäder [Tue, 16 Apr 2019 05:16:51 +0000 (07:16 +0200)]
grid: Fix annotation typo
Emmanuele Bassi [Tue, 16 Apr 2019 10:43:23 +0000 (11:43 +0100)]
Add licensing and copyright notice to report generators
So that other projects can use them.
Benjamin Otte [Sat, 26 Jan 2019 14:09:55 +0000 (15:09 +0100)]
build: Add new gcc error flags
These flags check for code that we don't want to write, so turn them
into error flags.
Variable length arrays should be replaced by malloc() - or explicit
alloca() calls if you know what you're doing.
Implicit fallthrough should be replaced by explicit fallthrough with the
usage of G_GNU_FALLTHROUGH.
This work inspired by Kees Cook's LCA2019 talk:
https://www.youtube.com/watch?v=FY9SbqTO5GQ
http://outflux.net/slides/2019/lca/danger.pdf
Benjamin Otte [Sat, 26 Jan 2019 14:09:33 +0000 (15:09 +0100)]
Add missing G_GNUC_FALLTHROUGH statements
Benjamin Otte [Sat, 26 Jan 2019 14:05:06 +0000 (15:05 +0100)]
Convert fallthrough comments to G_GNUC_FALLTHROUGH
This way it's very obvious that fallthrough is indeed what we want.
Also bump the glib requirement to 2.59 which introduced
G_GNUC_FALLTHROUGH.
Benjamin Otte [Sat, 26 Jan 2019 14:37:05 +0000 (15:37 +0100)]
filechoosernativewin32: Add missing break statement
Benjamin Otte [Sat, 26 Jan 2019 14:07:52 +0000 (15:07 +0100)]
notebook: Add missing return statement
Previously, the code would just fall thrrough and repeat an operation it
had tried before, but that seems quite unnecessary.
Benjamin Otte [Sat, 26 Jan 2019 13:30:06 +0000 (14:30 +0100)]
textview: Add missing break statement
Benjamin Otte [Sat, 26 Jan 2019 13:28:48 +0000 (14:28 +0100)]
vulkan: Add missing break statement
Benjamin Otte [Mon, 15 Apr 2019 02:19:28 +0000 (04:19 +0200)]
menu: Remove unused function parameter
The parameter was only ever set to TRUE.
And to make matters even more fun, the function didn't ever look
at the parameter.
Benjamin Otte [Sun, 14 Apr 2019 22:45:46 +0000 (00:45 +0200)]
menu: Move enum into only source file using it
Benjamin Otte [Sun, 14 Apr 2019 22:42:57 +0000 (00:42 +0200)]
menu: remove bottom attach
bottom attach is top attach + 1, so use that everywhere
Benjamin Otte [Sat, 13 Apr 2019 10:36:34 +0000 (12:36 +0200)]
menu: get rid of 2 variables
They are always 0 and 1 respectively, so treat the code like that.
Benjamin Otte [Sat, 13 Apr 2019 10:26:10 +0000 (12:26 +0200)]
menu: Yeah cool, you're the last child
Nobody cares.
Benjamin Otte [Sat, 13 Apr 2019 10:17:57 +0000 (12:17 +0200)]
menu: Remove attach properties
They're never changed from being -1. So just replace them with -1
everywhere.
Benjamin Otte [Sat, 13 Apr 2019 09:58:38 +0000 (11:58 +0200)]
menubar: Remove pack direction
Benjamin Otte [Sat, 13 Apr 2019 09:58:12 +0000 (11:58 +0200)]
tests: Remove popupat test
The test hasn't worked for a while and nobody cared to fix it.
Neither do I.
Emmanuele Bassi [Sun, 14 Apr 2019 19:56:11 +0000 (20:56 +0100)]
ci: Restructure the HTML report
We should show all the possible result sections:
- passed
- skipped
- expected failures
- failures
- timed out
Even if we consider the first three to be successes.
Emmanuele Bassi [Sun, 14 Apr 2019 19:37:21 +0000 (20:37 +0100)]
ci: Tweak the HTML report style
The header needs to take into account the job id field.
Emmanuele Bassi [Sun, 14 Apr 2019 19:29:14 +0000 (20:29 +0100)]
ci: Style the test report
My web design skills are terrible, but it's better than nothing; I'm
sure this will lead to somebody filing a merge request to make the
test report look a lot better.
While we're at it, let's include the reftest images inside the report
itself, so we don't have to hunt them down.